New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate API with database #35

Merged

jmaupetit merged 1 commit into main from api-db-calls

May 6, 2024

Member

jmaupetit commented Apr 23, 2024 •

edited

Loading

Purpose

API calls should create and fetch database entries for statique and dynamique data. Let's start implementing the database integration logic.

Proposal

add models / schemas utilities so that we separate business logic from the API
save Statique model to database
fetch Statique model from database
handle database updates from Statique object
update the CHANGELOG

jmaupetit marked this pull request as draft

April 23, 2024 18:31

jmaupetit self-assigned this

jmaupetit commented

View reviewed changes

src/api/tests/models/test_static.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/utils.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/utils.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/utils.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/utils.py Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/utils.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/static.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/static.py Outdated Show resolved Hide resolved

jmaupetit commented

View reviewed changes

src/api/qualicharge/schemas/utils.py Show resolved Hide resolved

jmaupetit marked this pull request as ready for review

May 6, 2024 10:35

jmaupetit commented

View reviewed changes

src/api/qualicharge/factories/static.py Outdated Show resolved Hide resolved


          ✨(api) implement statique endpoints

9f0838f

Current work adds helpers to create database entries from `Statique`
objects. It allows to separate the business logic from API endpoints
implementation.

Two possible improvements concerning the current implementation:

- the /bulk endpoint performances should not depend on the number of
  submitted statiques.
- Statique update can lead to orphan entries as we might create new
  related entries instead of patching them. Since we do not rely on
  object ids on this part, it's a fair trade-off for now.

jmaupetit force-pushed the api-db-calls branch from 514061d to 9f0838f Compare

May 6, 2024 14:07

jmaupetit merged commit 69afedb into main

8 checks passed

jmaupetit deleted the api-db-calls branch

May 6, 2024 14:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet