👔(dashboard) disallow delete action for consents in admin. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssorin
added
improvement
needs review
WIP
dashboard
Added `has_delete_permission` method to disable the delete action for all users in the Consent admin. Included tests to ensure deletion is disallowed for existing objects and when no object is passed. Updated the changelog accordingly.
ssorin
force-pushed
the
feature/dashboard/remove-delete-action-in-admin
branch
from
bfcfb16 to
ffe721a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In admin, the deletion of
validatedandrevokedconsents must not be allowed.Proposal
has_delete_permissionmethod to disable the delete action for all users in the Consent admin