-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Data7 configuration #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
added
improvement
needs review
opendata
Item related to the opendata service
labels
Jan 8, 2025
jmaupetit
force-pushed
the
fix-data7-uvicorn-boot
branch
from
January 8, 2025 09:11
240200f
to
294d093
Compare
loco-philippe
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok pour la requete,
on peut éviter une jointure avec :
WITH
pdc_status AS (
SELECT
LAST (Status.id, Status.horodatage) AS latest_id,
id_pdc_itinerance
FROM
PointDeCharge
INNER JOIN Status ON Status.point_de_charge_id = PointDeCharge.id
GROUP BY
PointDeCharge.id_pdc_itinerance
)
SELECT
-- PointDeCharge.id_pdc_itinerance,
Status.etat_pdc,
Status.occupation_pdc,
Status.horodatage,
Status.etat_prise_type_2,
Status.etat_prise_type_combo_ccs,
Status.etat_prise_type_chademo,
Status.etat_prise_type_ef
FROM
Status
-- INNER JOIN PointDeCharge ON Status.point_de_charge_id = PointDeCharge.id
WHERE
Status.id IN (
SELECT
latest_id
FROM
pdc_status
)
ORDER BY
Status.horodatage DESC
Non,c'est pas bon du tout. J'ai été trop vite!!! |
jmaupetit
force-pushed
the
fix-data7-uvicorn-boot
branch
from
January 8, 2025 18:01
9b231f8
to
294d093
Compare
As the opendata application is not supposed to get a high traffic (thanks to the NAP), a single worker with minimal configuration would be sufficient. This will avoid consuming too much RAM.
This new release upgrade dependencies and allows to configure Sentry's profiling.
Now that we have real world statuses, we can provide a relevant timescaleDB based database query.
jmaupetit
force-pushed
the
fix-data7-uvicorn-boot
branch
from
January 8, 2025 18:02
294d093
to
8e3ffcb
Compare
Current benchmark
Comparison with the latest previous benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Now that we have production-ready data, we need to carefully configure data7 given its usage.
Proposal
0.9.0