✨(dashboard) add signals on delivery point creation #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssorin
added
feature
needs review
dashboard
ssorin
force-pushed
the
feature/dashboard/add-consent-signals
branch
from
cd543e6 to
bc33710
Compare
jmaupetit
reviewed
Dec 19, 2024
ssorin
force-pushed
the
feature/dashboard/add-consent-signals
branch
5 times, most recently
from
f028777 to
0df1e8b
Compare
jmaupetit
reviewed
Dec 20, 2024
ssorin
force-pushed
the
feature/dashboard/add-consent-signals
branch
from
0df1e8b to
e18d9df
Compare
jmaupetit
reviewed
Dec 20, 2024
ssorin
force-pushed
the
feature/dashboard/add-consent-signals
branch
2 times, most recently
from
92936b5 to
9fd7a85
Compare
4 tasks
jmaupetit
reviewed
Jan 8, 2025
ssorin
force-pushed
the
feature/dashboard/add-consent-signals
branch
from
9fd7a85 to
fd5c01c
Compare
Implemented a signal to automatically create a Consent object when a new DeliveryPoint is saved. Added corresponding tests to ensure functionality and updated related Pipfile dependencies. Centralized consent end date logic in a new app settings file (CONSENT_END_DATE) and updated all related signals, factories, and tests to use it. Updated documentation and code comments to reflect these changes.
ssorin
force-pushed
the
feature/dashboard/add-consent-signals
branch
from
fd5c01c to
2149df1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When a new
delivery pointis created, the associatedconsentmust be automatically created as awaiting consent.Proposal