Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 (dashboard) add linter #216

Merged
merged 1 commit into from
Nov 13, 2024
Merged

🚧 (dashboard) add linter #216

merged 1 commit into from
Nov 13, 2024

Conversation

ssorin
Copy link
Collaborator

@ssorin ssorin commented Nov 6, 2024

  • add dev dependencies (black, ruff, mypy, django-stubs, pre-commit)
  • add lint and test commands to Makefile
  • configure ruff, mypy and pre-commit
  • reformat code with ruff ans black
  • [wip] add a GitHub Actions workflow for CI/CD

jmaupetit
jmaupetit reviewed Nov 7, 2024
View reviewed changes
src/dashboard/pyproject.toml Outdated Show resolved Hide resolved
src/dashboard/mypy.ini Outdated Show resolved Hide resolved
src/dashboard/apps/dashboard/settings.py Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/dashboard/Pipfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@jmaupetit jmaupetit added feature WIP dashboard Item related to the Dashboard service and removed feature labels Nov 7, 2024
@ssorin ssorin force-pushed the add-dashboard-linter branch from 929051d to 2b432c7 Compare November 8, 2024 11:58
@ssorin ssorin marked this pull request as ready for review November 8, 2024 12:01
@ssorin ssorin marked this pull request as draft November 8, 2024 12:06
@ssorin ssorin force-pushed the add-dashboard-linter branch 5 times, most recently from e9461b8 to 18b5089 Compare November 8, 2024 15:36
@jmaupetit jmaupetit marked this pull request as ready for review November 8, 2024 15:36
jmaupetit
jmaupetit reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! 👍

Concerning linters configuration, we should be as much homogeneous as possible across services, and discuss possible evolution that should apply globally.

.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
src/dashboard/apps/dashboard/asgi.py Outdated Show resolved Hide resolved
src/dashboard/pyproject.toml Outdated Show resolved Hide resolved
src/dashboard/pyproject.toml Outdated Show resolved Hide resolved
src/dashboard/pyproject.toml Outdated Show resolved Hide resolved
src/dashboard/pyproject.toml Outdated Show resolved Hide resolved
jmaupetit
jmaupetit reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have minor comments 😎

.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
src/dashboard/Pipfile Outdated Show resolved Hide resolved
.github/workflows/dashboard.yml Outdated Show resolved Hide resolved
src/dashboard/dashboard/settings.py Outdated Show resolved Hide resolved
src/dashboard/dashboard/settings.py Outdated Show resolved Hide resolved
src/dashboard/pyproject.toml Outdated Show resolved Hide resolved
@ssorin ssorin force-pushed the add-dashboard-linter branch 3 times, most recently from 885ea9b to bd8333a Compare November 13, 2024 12:46
jmaupetit
jmaupetit approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssorin
👷(dashboard) add linters, pytest and github workflow
8e5292e 
- add linter dependencies : black, ruff, mypy
- add pytest dependencies
- add linters and pytest configuration in pyproject.toml
- add linter and test command in Makefile
- move the dashboard Django app from src/dashboard/apps to src/dashboard/
- add github workflow for dashboard (dashboard.yml)
@ssorin ssorin force-pushed the add-dashboard-linter branch from 5ef6b4f to 8e5292e Compare November 13, 2024 13:43
@ssorin ssorin merged commit 19fef18 into main Nov 13, 2024
19 of 20 checks passed
@ssorin ssorin deleted the add-dashboard-linter branch November 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaupetit jmaupetit jmaupetit approved these changes

Assignees

@ssorin ssorin

Labels
dashboard Item related to the Dashboard service WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssorin @jmaupetit