-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Lister toutes les demandes de changement de représentant légal (demandée/accordée/rejetée) #2653
Merged
JulienPavon
merged 14 commits into
main
from
feat/representant-legal/list-with-all-changes-requested
Jan 24, 2025
Merged
✨ Lister toutes les demandes de changement de représentant légal (demandée/accordée/rejetée) #2653
JulienPavon
merged 14 commits into
main
from
feat/representant-legal/list-with-all-changes-requested
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spontoreau
previously approved these changes
Jan 23, 2025
HubM
requested changes
Jan 23, 2025
...cribers/lauréat/représentant-légal/changement/changementReprésentantLégalAnnulé.projector.ts
Outdated
Show resolved
Hide resolved
...cribers/lauréat/représentant-légal/changement/changementReprésentantLégalAnnulé.projector.ts
Outdated
Show resolved
Hide resolved
...cribers/lauréat/représentant-légal/changement/changementReprésentantLégalRejeté.projector.ts
Outdated
Show resolved
Hide resolved
...cribers/lauréat/représentant-légal/changement/changementReprésentantLégalRejeté.projector.ts
Outdated
Show resolved
Hide resolved
...ibers/lauréat/représentant-légal/changement/changementReprésentantLégalSupprimé.projector.ts
Outdated
Show resolved
Hide resolved
...ibers/lauréat/représentant-légal/changement/changementReprésentantLégalSupprimé.projector.ts
Outdated
Show resolved
Hide resolved
VioMrqs
reviewed
Jan 23, 2025
...n/lauréat/src/représentantLégal/changement/lister/listerChangementReprésentantLégal.query.ts
Outdated
Show resolved
Hide resolved
VioMrqs
reviewed
Jan 23, 2025
JulienPavon
force-pushed
the
feat/representant-legal/list-with-all-changes-requested
branch
from
January 23, 2025 15:22
58e8006
to
ff6c7fa
Compare
HubM
previously approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testée et approuvée
VioMrqs
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques remarques, notamment pour la projection
...ribers/lauréat/représentant-légal/changement/changementReprésentantLégalAccordé.projector.ts
Outdated
Show resolved
Hide resolved
packages/domain/lauréat/src/représentantLégal/représentantLégal.entity.ts
Show resolved
Hide resolved
...ibers/lauréat/représentant-légal/changement/changementReprésentantLégalSupprimé.projector.ts
Show resolved
Hide resolved
...src/subscribers/lauréat/tâche-planifiée/handleReprésentantLégalRappelInstructionÀDeuxMois.ts
Outdated
Show resolved
Hide resolved
...es/applications/legacy/src/controllers/project/getProjectPage/_utils/getReprésentantLégal.ts
Outdated
Show resolved
Hide resolved
VioMrqs
approved these changes
Jan 24, 2025
JulienPavon
deleted the
feat/representant-legal/list-with-all-changes-requested
branch
January 24, 2025 11:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification de l'identifiant de la projection des changement en y ajoutant la date de la demande
Ajout de la date en argument de la query
ConsulterChangementReprésentantLégalQuery
Changement de structure des répertoires des pages de changement de représentant légal pour avoir dans l'url la date
Modification des projecteurs pour rechercher depuis le représentant légal pour pouvoir récupérer la date du changement en cours pour mettre à jour la projection
représentant-legal