[Mission] Delete setFieldValue in useEffect - Awareness component

MTES-MCT · Jan 23, 2025 · 9429065 · 9429065
1 parent 5379dc4
commit 9429065
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/...end/src/features/Mission/components/MissionForm/ActionForm/SurveillanceForm/Awareness.tsx b/...end/src/features/Mission/components/MissionForm/ActionForm/SurveillanceForm/Awareness.tsx
@@ -1,4 +1,4 @@
-import { FormikCheckbox, FormikNumberInput, FormikSelect, Label } from '@mtes-mct/monitor-ui'
+import { Checkbox, FormikNumberInput, FormikSelect, Label } from '@mtes-mct/monitor-ui'
 import { useField, useFormikContext } from 'formik'
 import { useEffect } from 'react'
 import styled from 'styled-components'
@@ -22,21 +22,28 @@ export function Awareness({ awarenessOptions, formPath }: AwarenessProps) {
     if (controlPlans.value.length === 1 && isRisingAwareness) {
       setFieldValue(`${formPath}.awareness.themeId`, controlPlans.value[0]?.themeId)
     }
-    if (!isRisingAwareness) {
+  }, [controlPlans.value, formPath, isRisingAwareness, setFieldValue])
+
+  const updateIsRisingAwareness = (isChecked: boolean | undefined) => {
+    if (isChecked) {
+      setFieldValue(`${formPath}.awareness`, { isRisingAwareness: true })
+    } else {
       setFieldValue(`${formPath}.awareness`, undefined)
     }
-  }, [controlPlans.value, formPath, isRisingAwareness, setFieldValue])
+  }
 
   return (
     <>
       <div>
         <Label>Prévention</Label>
-        <FormikCheckbox
+        <Checkbox
+          checked={isRisingAwareness}
           data-cy="surveillance-awareness"
           inline
           isLight
           label="La surveillance a donné lieu à des actions de prévention"
           name={`${formPath}.awareness.isRisingAwareness`}
+          onChange={updateIsRisingAwareness}
         />
       </div>
 

diff --git a/frontend/src/features/Mission/components/MissionForm/constants.ts b/frontend/src/features/Mission/components/MissionForm/constants.ts
@@ -11,7 +11,8 @@ export const MISSION_EVENT_UNSYNCHRONIZED_PROPERTIES = [
   // `envActions` is included but `reportingIds` is missing
   'envActions',
   'fishActions',
-  'hasRapportNavActions'
+  'hasRapportNavActions',
+  'observationsByUnit'
 ]
 
 export const MISSION_EVENT_UNSYNCHRONIZED_PROPERTIES_IN_FORM = [