feat(ceased-activity): display ceased activty employments in Mes Informations #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
question: je ne vois pas de changements liés au fait que :
|
sandrica89
reviewed
Mar 24, 2025
| @@ -11,6 +12,7 @@ export const EMPLOYMENT_ROLE = { | |||
| }; | |||
|
|
|||
| export function getEmploymentsStatus(employment) { | |||
| if (employment.company?.hasCeasedActivity) return EMPLOYMENT_STATUS.ceased; | |||
| if (!employment.isAcknowledged) return EMPLOYMENT_STATUS.pending; | |||
There was a problem hiding this comment.
question: à quoi correspond "isAknowledged" ? pourquoi ne pas utiliser le "validationStatus = 'pending'" ?
| @@ -11,6 +12,7 @@ export const EMPLOYMENT_ROLE = { | |||
| }; | |||
|
|
|||
| export function getEmploymentsStatus(employment) { | |||
There was a problem hiding this comment.
question: dans cette méthode, tu ne regardes pas si l'employment est dismissed ; ce n'est pas pertinent ici ?
Vu qu'on met fin aux rattachements pour les entreprises cessées, il n'est plus possible pour un gestionnaire d'accéder à cette entreprise ni à un salarié de logguer pour celle-ci |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/QyTb4Q1x/1633-suppression-des-comptes-entreprise-qui-nexistent-plus