Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Mocker BAN API #3674

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[QA] Mocker BAN API #3674

merged 2 commits into from
Feb 5, 2025

Conversation

sfinx13
Copy link
Collaborator

@sfinx13 sfinx13 commented Feb 4, 2025

Ticket

#3673

Description

  • Mocker Appel BAN API dans SignalementViewedSubscriberTest et SignalementEditControllerTest pour éviter de faire planter les tests si l'API ne répond pas.

Changements apportés

  • Remplacer les appels par des mock
  • Ajout json pour réprésenter les réponses à simuler

Pré-requis

Tests

  • CI OK

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

hmeneuvrier
hmeneuvrier approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi

numew
numew approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@numew numew merged commit b95e7d4 into develop Feb 5, 2025
4 checks passed
@sfinx13 sfinx13 deleted the bugfix/3673-mock-call-banapi branch March 13, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numew numew numew approved these changes

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@emilschn emilschn Awaiting requested review from emilschn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfinx13 @numew @hmeneuvrier