Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BO - Signalement] Pouvoir éditer la géolocalisation dans la fiche #3659

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[BO - Signalement] Pouvoir éditer la géolocalisation dans la fiche #3659

wants to merge 1 commit into from

Conversation

numew
Copy link
Collaborator

@numew numew commented Feb 3, 2025 •
edited by emilschn
Loading

Ticket

#3594

Description

  • Modification du "Voir la carte" qui ouvre à présent une modale
  • Quand le signalement n'est pas géolocalisé, le "Voir la carte" est remplacé par un "Sélectionner le bâtiment sur la carte" qui affiche le sélecteur de bâtiments du RNB

Pré-requis

npm install
npm run watch
make load-fixtures

Tests

Se rendre sur le signalement http://localhost:8080/bo/signalements/00000000-0000-0000-2025-000000000004

  • Tester le fonctionnement du système de sélection de bâtiment
  • S'assurer qu’après la sélection d'un bâtiment la localisation "Voir la carte" est bien positionnée

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

emilschn
emilschn approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@emilschn emilschn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lecture et test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn approved these changes

@hmeneuvrier hmeneuvrier Awaiting requested review from hmeneuvrier

@sfinx13 sfinx13 Awaiting requested review from sfinx13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@numew @emilschn