[QA] Suppression de ActivityListener #3629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilschn
commented
Jan 28, 2025
| @@ -134,7 +134,7 @@ public function addSuiviSignalement( | |||
|
|
|||
| $this->addFlash('success', 'Suivi publié avec succès !'); | |||
| } else { | |||
| $this->addFlash('error', 'Une erreur est survenue lors de la publication.'); | |||
| $this->addFlash('error', 'Une erreur de jeton est survenue lors de la publication.'); | |||
There was a problem hiding this comment.
j'ai précisé cette erreur ici, parce qu'il y avait une erreur similaire juste au-dessus, et j'aime pas quand deux erreurs différentes retournent le même texte :)
emilschn
force-pushed
the
feature/3610-remove-activity-listener
branch
from
0d5baff to
042a987
Compare
hmeneuvrier
reviewed
Jan 29, 2025
| private function send(NotificationMailerType $notificationMailerType, ArrayCollection $recipients, bool $isInAppNotificationCreated = false): void | ||
| { | ||
| if ($isInAppNotificationCreated) { | ||
| foreach ($recipients as $user) { | ||
| $this->createInAppNotification($user); | ||
| if ($user instanceof User) { |
There was a problem hiding this comment.
est-ce qu'on ne fait pas le ticket #3626 dans la foulée ici ?
There was a problem hiding this comment.
Je suis pas trop pour modifier des comportements dans cette PR
There was a problem hiding this comment.
ouais je suis d'accord ; dans l'idéal, il faudrait presque que celle-ci soit en prod avant d'entamer l'autre :p ça facilite la détection d'erreur
numew
reviewed
Jan 29, 2025
tests/Functional/Controller/Back/SignalementListControllerTest.php
Outdated
Show resolved
Hide resolved
tests/Functional/Service/Notification/NotificationCounterTest.php
Outdated
Show resolved
Hide resolved
emilschn
force-pushed
the
feature/3610-remove-activity-listener
branch
from
43d6bcf to
1f5f0d9
Compare
emilschn
force-pushed
the
feature/3610-remove-activity-listener
branch
from
1a82229 to
89f3f11
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3610
Description
Finalisation du nouveau service d'envoi de mails et notifications internes. Déplacement de l'enregistrement des suivis dans un événement spécifique.
Suppression du ActivityListener.
Tests
(désolé, je préfère rester vague, parce que si je suis trop précis sur une liste d'actions, j'ai peur d'en louper certaines qui ne seraient pas testées...)