[QA - Sentry] Les fichiers de format ne sont pas pris en charge #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmeneuvrier
commented
Jan 24, 2025
hmeneuvrier
commented
Jan 24, 2025
| $acceptedExtensions = UploadHandlerService::getAcceptedExtensions('photo'); | ||
| $message = <<<ERROR | ||
| $fileInfo = ' ( Fichier : '.$file->__toString().' MimeType : '.$file->getMimeType().' )'; | ||
| $this->logger->error($message.$fileInfo); |
There was a problem hiding this comment.
J'enlèverais bien aussi les logs sur sentry pour des formats non supportés... non ?
There was a problem hiding this comment.
Je suis ok, mais y'avait peut-être une raison derrière ça ?
hmeneuvrier
commented
Jan 24, 2025
| if (\in_array($file->getMimeType(), File::IMAGE_MIME_TYPES)) { | ||
| $this->imageManipulationHandler->setUseTmpDir(false)->resize($filename)->thumbnail($filename); | ||
| $fileInfo = ' ( Fichier : '.$file->__toString().' MimeType : '.$file->getMimeType().' )'; | ||
| $this->logger->error($message.$fileInfo); |
hmeneuvrier
force-pushed
the
bugfix/3336-qa---sentry-check-size-format-type
branch
from
c8b5dcb to
6c34f91
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3336
Description
J'ai fait le tour des erreurs sentry de ce type des 30 derniers jours.
Il y avait 2 cas possibles :
Changements apportés
Pré-requis
Désacctiver la vérification js
Tests