Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections multi-territoires #3609

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Corrections multi-territoires #3609

merged 5 commits into from
Jan 24, 2025

Conversation

numew
Copy link
Collaborator

@numew numew commented Jan 23, 2025

Ticket

#3602 #3603 #3604 #3605

Description

  • Ajout d'un message d'information et changement de l'intitulé du bouton submit de la modale d'ajout d'un agent existant sur un partenaire
  • Modification du message de succès suite à l'ajout d'un agent existant sur un partenaire
  • Modification du label "Prenom" en "Prénom" sur le formulaire de création d'un agent
  • Correction de la fonction getPartnerInTerritoryOrFirstOne qui retournait toujours le premiere partenaire de l'user et provoquait des problème de droits pour les utilisateur multi-territoire

Tests

  • Vérifier les 4 points indiqués en description

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit rappel ne pas oublier de lancer un make es-js-fix

Comment on lines 285 to 289
if(response.submitLabel){
document.querySelector(modalSelector + ' button[type="submit"]').innerHTML = response.submitLabel
}else{
document.querySelector(modalSelector + ' button[type="submit"]').innerHTML = 'Valider'
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petite ternaire

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok c'est fait (et le make es-js-fix que je ne fais jamais aussi)

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test des 4 tickets OK

Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK (en attente de la CI)

@sfinx13 sfinx13 merged commit 18503cc into develop Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants