Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression de la notion de financement sur le modèle convention #1726

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kolok
Copy link
Collaborator

@kolok kolok commented Jan 31, 2025

Description succincte du problème résolu

On ne garde la notion de financement uniquement sur l'objet Lot
Suppression sur l'objet convention

Bien tester :

  • la génération de doc (Fiche CAF incluse)
  • le lien avec le SIAP
  • toutes les étapes de la convention en particulier EDD, logement et financement

N'oublier pas de taguer : bug, enhancement, documentation, technical, dependencies (+ escalation, regression si besion)

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

@kolok kolok changed the title Suppression de la notion de financement sur le modèle convnetion Suppression de la notion de financement sur le modèle convention Jan 31, 2025
@kolok kolok marked this pull request as ready for review January 31, 2025 10:30
@kolok kolok requested a review from a team as a code owner January 31, 2025 10:30
@kolok kolok requested review from etchegom and syldb and removed request for a team January 31, 2025 10:30
Copy link

github-actions bot commented Jan 31, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8533 7066 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/admin.py 74% 🟢
conventions/forms/convention_form_financement.py 85% 🟢
conventions/models/convention.py 88% 🟢
conventions/services/search.py 96% 🟢
conventions/services/selection.py 95% 🟢
programmes/api/operation_serializers.py 91% 🟢
programmes/models/models.py 97% 🟢
programmes/services.py 91% 🟢
siap/siap_client/utils.py 71% 🟢
TOTAL 88% 🟢

updated for commit: 0e15373 by action🐍

Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant