Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout de financements manquant #1713

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Ajout de financements manquant #1713

merged 6 commits into from
Feb 7, 2025

Conversation

kolok
Copy link
Collaborator

@kolok kolok commented Jan 24, 2025

Description succincte du problème résolu

Carte Airtable / Lien Mattermost : S1101: Ajouter de nouveaux types de financement

Ajout des financements manquants

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

Comment tester

En local / staging :

  • …

@kolok kolok added the enhancement New feature or request label Jan 24, 2025
@kolok kolok requested a review from a team as a code owner January 24, 2025 13:47
@kolok kolok requested review from etchegom and syldb and removed request for a team January 24, 2025 13:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8556 7092 83% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
conventions/admin.py 74% 🟢
conventions/forms/convention_form_financement.py 85% 🟢
conventions/forms/type1and2.py 100% 🟢
conventions/models/convention.py 88% 🟢
programmes/models/choices.py 96% 🟢
siap/siap_client/utils.py 74% 🟢
TOTAL 86% 🟢

updated for commit: 4065a32 by action🐍

kolok
kolok commented Jan 24, 2025
View reviewed changes
Copy link
Collaborator Author

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vérifier les règles de financement

@kolok kolok marked this pull request as draft January 24, 2025 13:53
@kolok kolok marked this pull request as ready for review January 31, 2025 09:03
etchegom
etchegom approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@etchegom etchegom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kolok kolok merged commit 349e8d5 into main Feb 7, 2025
9 checks passed
@kolok kolok deleted the other_fin branch February 7, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etchegom etchegom etchegom approved these changes

@syldb syldb Awaiting requested review from syldb syldb is a code owner automatically assigned from MTES-MCT/apilos

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolok @etchegom