Use libreoffice to generate pdf file from docx #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
kolok
force-pushed
the
poc_libreoffice
branch
from
6da5842 to
38c6743
Compare
kolok
force-pushed
the
poc_libreoffice
branch
3 times, most recently
from
e41fe05 to
58d869b
Compare
etchegom
force-pushed
the
poc_libreoffice
branch
from
ffbaf02 to
14e2c8c
Compare
etchegom
reviewed
Mar 21, 2024
etchegom
force-pushed
the
poc_libreoffice
branch
from
46fa705 to
1b2167b
Compare
kolok
force-pushed
the
poc_libreoffice
branch
2 times, most recently
from
29ee271 to
bca4e9d
Compare
etchegom
force-pushed
the
poc_libreoffice
branch
2 times, most recently
from
4fd8a42 to
9c85e38
Compare
etchegom
changed the title
etchegom
reviewed
Apr 4, 2024
| @@ -82,7 +83,7 @@ def _compute_total_locaux_collectifs(convention): | |||
| ) | |||
|
|
|||
|
|
|||
| def generate_convention_doc(convention: Convention, save_data=False): | |||
| def generate_convention_doc(convention: Convention, save_data=False) -> DocxTemplate: | |||
There was a problem hiding this comment.
Ca me parait mieux que generate_convention_doc retourne une instance de doc plutôt que des bytes.
Ca simplifie également par la suite ici, pour l'écriture dans un fichier local.
etchegom
reviewed
Apr 4, 2024
Comment on lines
+284
to
+306
| def get_tmp_local_path() -> Path: | ||
| local_path = Path(settings.MEDIA_ROOT, "tmp") | ||
| local_path.mkdir(parents=True, exist_ok=True) | ||
| return local_path |
There was a problem hiding this comment.
Proposition: écrire les fichiers locaux temporaire dans un répertoire "tmp" plutôt qu'à la racine.
etchegom
reviewed
Apr 4, 2024
Comment on lines
+323
to
+355
| except (subprocess.CalledProcessError, OSError) as err: | ||
| raise PDFConversionError from err |
There was a problem hiding this comment.
Note: il y a sûrement d'autres exceptions à catcher ici
etchegom
reviewed
Apr 4, 2024
Comment on lines
+30
to
+37
| chain( | ||
| task_generate_pdf.s(convention_uuid), | ||
| task_send_email_to_bailleur.si( | ||
| convention_uuid, | ||
| convention_url, | ||
| convention_email_validator, | ||
| ), |
There was a problem hiding this comment.
La feature Celery chain permet de lier les deux tâches et d'ajuster ainsi les paramètre de retry à chacune d'elle.
etchegom
reviewed
Apr 4, 2024
core/settings.py
Outdated
| @@ -575,6 +575,7 @@ def get_env_variable(name, cast=str, default=""): | |||
| CELERY_SEND_EVENTS = True | |||
| CELERY_ACKS_LATE = True | |||
| CELERY_WORKER_MAX_TASKS_PER_CHILD = 5000 | |||
| CELERY_ALWAYS_EAGER = get_env_variable("CELERY_ALWAYS_EAGER", cast=bool, default=False) | |||
There was a problem hiding this comment.
etchegom
requested review from
etchegom and
syldb
and removed request for
a team
kolok
commented
Apr 5, 2024
etchegom
force-pushed
the
poc_libreoffice
branch
2 times, most recently
from
fe1f084 to
cb64a55
Compare
syldb
approved these changes
Apr 30, 2024
etchegom
approved these changes
Apr 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do