-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/python service call encoding #63
base: develop
Are you sure you want to change the base?
Fix/python service call encoding #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch, thanks for the PR, @Aposhian !
I don't like including the pybind11 headers in the library public headers, but they are protected with a macro so as long as users w/o python don't get affected, it's good enough! There seems to be no alternative if one wants to use py::bytes
👍
Please, just make sure of passing clang-format script and check tabs vs spaces in cmake, and I'll glad to merge once CI is also happy.
Ok, I ran the formatter script, and changed my tabs in my cmake additions to spaces. I should have noted that I can see a few other ways to solve this problem and use
|
The only way I can think of to make it work with splitting out the py::bytes function into a separate file is to subclass |
Ok, @Aposhian , don't worry about the "#include" in the header, as long as all CI pass we could live with that :-) But please check the failing CI runs above. It's painful, but to support different versions of pybind with the same sources, I had to add some #if (PYBIND11_MAJOR_VERSION == 2 && PYBIND11_MINOR_VERSION <= 4) here, and apply that technique to all the places where the github actions above fail. I'll approve the changes and leave this in "auto-merge" so once all CI tests pass, it won't require manual actions. Thanks! |
Head branch was pushed to by a user without write access
Running into some issues with testing this. The imported symbol can't be resolved in the .so. |
It's weird... I tested it to build OK locally. But "make test" fails with a protobuf error. Have you tried "make test" yourself too? If it fails, I feel it's close but... we'll have to carefully check all changes in the PR for the reason of this 😢 |
Addresses #62
This also makes some tweaks to the generate-python.sh script, and also regenerates the pybind11 wrappers. The diff is larger than I would expect, so not sure if there is a mismatch in binder version or other settings. Happy to make changes as needed.