Fix crash for non-ASCII characters #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_DataManagerthrows aUnicodeDecodeErrorif the message contains a non-ASCII character that can be encoded with latin-1 encoding, e.g.,°. The message is encoded with latin-1 and then decoded withdecode(). Thedecode()function without arguments defaults to UTF-8 encoding, so the code attempts to UTF-8 decode a message encoded with latin-1, causing the exception. I fixed this problem by passing the correct encoding todecode().I further removed the UTF-8 encoding / decoding since the result is not used, and the latin-1 encoding / decoding is stricter anyway.