Skip to content

Conversation

@MarilynKeller
Copy link

This merge request fixes a compilation error that occurred when building with:

NumPy 2.2.6
Python 3.10.0

The issue was due to incorrect type casting when passing PyObject* to PyArray_DATA and PyArray_DIMS, which now expects a const PyArrayObject* as of recent NumPy versions.

Changes

Explicit cast added in mesh/src/*.cpp

PyArray_DATA(py_v) -> PyArray_DATA((PyArrayObject*)py_v)
PyArray_DIMS(py_v) -> PyArray_DATA((PyArrayObject*)py_v)

Makefile updated:

l.7 -- 	--install-option  -> --config-settings 

As --install-option is not supported by modern pip

@mlouielu
Copy link

For who may want to install directly:

python -m pip install git+https://github.com/MPI-IS/mesh@e8b04be3aaa1d262a3b7a05ef9e4085b4836b049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants