Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put null check on result at onImagePicked method #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meshhh-003
Copy link

by putting null check on result if image result comes null then app will not crash and it siply shows toast and return.

@Meshhh-003
Copy link
Author

is this a good approach to stop crashing app ? or should i use try catch block ?
private fun onImagePicked(result: Any) {
if (result == null){
Toast.makeText(this, java.lang.String.format("result is null"), Toast.LENGTH_LONG).show()
return
}
Toast.makeText(this, java.lang.String.format("Result: %s", result), Toast.LENGTH_LONG).show()
if (result is Bitmap) {
ivPickedImage.setImageBitmap(result)
} else {
Glide.with(this)
.load(result) // works for File or Uri
.transition(DrawableTransitionOptions().crossFade())
.into(ivPickedImage)
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant