Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User profile component added #82

Merged
merged 13 commits into from
Apr 8, 2021
Merged

User profile component added #82

merged 13 commits into from
Apr 8, 2021

Conversation

DebugAgrawal
Copy link
Member

Resolves #26

  • User Profile card
  • Users posts

bodhisha
bodhisha requested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@bodhisha bodhisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.. 🎉
I think you need to remove the changes in the package.json, and constants file

frontend/package.json Outdated Show resolved Hide resolved
frontend/src/constants.js Outdated Show resolved Hide resolved
bodhisha
bodhisha requested changes Apr 8, 2021
View reviewed changes
frontend/src/Components/UserProfile.js Outdated Show resolved Hide resolved
@DebugAgrawal DebugAgrawal added enhancement New feature or request client Related to client-side code (Frontend) labels Apr 8, 2021
aitikgupta
aitikgupta requested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@aitikgupta aitikgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more work with the URL end

package-lock.json Outdated Show resolved Hide resolved
frontend/src/Components/UserProfile.js Show resolved Hide resolved
frontend/src/Components/UserProfile.js Show resolved Hide resolved
@aitikgupta aitikgupta mentioned this pull request Apr 8, 2021
Open
aitikgupta
aitikgupta approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@aitikgupta aitikgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍🏼

@aitikgupta aitikgupta merged commit e271771 into main Apr 8, 2021
@bodhisha bodhisha deleted the user-component branch April 9, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhisha bodhisha bodhisha approved these changes

@aitikgupta aitikgupta aitikgupta approved these changes

Assignees
No one assigned
Labels
client Related to client-side code (Frontend) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Profile Page for User UI
3 participants
@DebugAgrawal @bodhisha @aitikgupta