Edit profile #140
Open
Edit profile #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Once again, do we really need those |
aitikgupta
added
client
aitikgupta
requested changes
Apr 17, 2021
Comment on lines
+14
to
+16
| const [accessToken, setAccessToken] = useState( | ||
| localStorage.getItem("access_token") | ||
| ); |
There was a problem hiding this comment.
Instead of getting accessToken here, you can directly use the AuthContext to get access token as well as a user (if you want) back from it. See:
SocioMark/frontend/src/Components/UserFeed.js
Lines 16 to 17 in 6c8857b
And this:
There was a problem hiding this comment.
Doing localStorage.getItem at multiple places might be concerning as if we ever wanted to change the key name, we'd have to do it at multiple places.
| @@ -4,6 +4,7 @@ | |||
| "private": true, | |||
| "dependencies": { | |||
| "@craco/craco": "^6.1.1", | |||
| "@headlessui/react": "^1.0.0", | |||
There was a problem hiding this comment.
I see we're adding it as a dependency, but the changes in package-lock.json are tooo huge to be just one package's addition? Or is that the case? :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to edit their name or description. Does not allow user to edit email.
Resolves #84
Screenshot:
