Verifying all coordinates are valid against master schema #437
Conversation
| "font_name": "4x6", | ||
| "start": 0, |
There was a problem hiding this comment.
This defaults to 0 in code
| @@ -188,6 +188,7 @@ | |||
| } | |||
| }, | |||
| "standings": { | |||
| "font_name": "4x6", | |||
There was a problem hiding this comment.
Just realized this will override the master font, so will need to update these where added.
| }, | ||
| "postseason": { | ||
| "matchup_y_gap": 12, | ||
| "series_x_gap": 32, | ||
| "wc_x_start": 3, | ||
| "wc_y_start": 12, | ||
| "ds_a_y_start": 51, | ||
| "__comment": "all other coords are based off wild card position" |
There was a problem hiding this comment.
Open to suggestions on this... Didn't look, but seems like if this is here then postseason brackets render, so may need to add an explicit enable/disable flag
| "nohit": { | ||
| "x": 46, | ||
| "y": 46 | ||
| }, | ||
| "perfect_game": { | ||
| "x": 46, | ||
| "y": 46 | ||
| } |
There was a problem hiding this comment.
I don't believe this is used anymore, but it's in most of the coordinates examples, so I added here.
There was a problem hiding this comment.
My custom layout uses this feature pretty extensively but not in any of the places the example does
|
I’d be nice to validate against a schema but having knowledge of the no-hitter/perfect game ideas without copying those from wherever they are in the schema. Probably also ignoring keys named “__comment” etc |
ty-porter
force-pushed
the
dev
branch
2 times, most recently
from
ae4887c to
cec8a9b
Compare
Addresses #432