Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.1.0 #372

Merged
merged 32 commits into from
May 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6a13390
Truncate team name if Runs or Hits > 9
tracerrx Apr 25, 2022
1fb2f7f
changed to abbreviation instead of truncate team name
tracerrx Apr 25, 2022
3c1bae3
Moved to renderer and added config option
tracerrx Apr 25, 2022
094aea2
Incorporated BW changes, appears to be working
tracerrx Apr 25, 2022
7923dbb
added option to show pregame weather to pitcher vs scroll
tracerrx Apr 26, 2022
6b3017f
Merge pull request #371 from MLB-LED-Scoreboard/master
ty-porter Apr 26, 2022
02a8529
Changed to truncate both team names when triggered, updated readme
tracerrx Apr 27, 2022
4e58d15
Add pitch data to pitches scoreboard item
WardBrian Apr 28, 2022
4aa3911
Integrated BW's pitch speeed into 128x64, added to colors, coordinates
tracerrx Apr 29, 2022
2512ab3
Add issue template and version information
ty-porter Apr 29, 2022
bd82303
Fix newline
ty-porter Apr 29, 2022
022adab
Added PITCH_LONG and PITCH_SHORT configurable dict
tracerrx Apr 29, 2022
772c212
Commit
tracerrx Apr 29, 2022
3788dfe
Update renderers/games/teams.py
tracerrx Apr 29, 2022
7dfc4f0
Update renderers/games/teams.py
tracerrx Apr 29, 2022
693d918
Added __can_use_full_team_names
tracerrx Apr 29, 2022
20ab1c4
added can_use_full_team_names
tracerrx Apr 29, 2022
e429320
Update 128x64 bord layout to show pitches
tracerrx Apr 29, 2022
b8713cf
Updated readme's for pitch data
tracerrx Apr 29, 2022
ff8fe0a
pitch data not display on all except 128x64 by default
tracerrx Apr 29, 2022
e0941b0
Merge pull request #369 from tracerrx/fix-teamname-rhe-display
ty-porter Apr 29, 2022
bb60e72
Skipped CU (curveball) entry
tracerrx Apr 30, 2022
6a5f6e7
Fix double logger in RGBME
ty-porter May 3, 2022
21f0451
Merge pull request #377 from ty-porter/logger
ty-porter May 3, 2022
c321189
Fix name abbreviation function
ty-porter May 4, 2022
e7d8f1d
Add missing return value
ty-porter May 4, 2022
9a47aee
Document nested conditionals
ty-porter May 4, 2022
b97a50f
Merge pull request #378 from ty-porter/shortname-patch
ty-porter May 4, 2022
df48117
Merge pull request #370 from tracerrx/add-pregame-weather
ty-porter May 4, 2022
08d0234
Merge pull request #374 from ty-porter/master
ty-porter May 4, 2022
01daa2c
Merge branch 'dev' into pitch-data
tracerrx May 10, 2022
f77e02c
Merge pull request #375 from tracerrx/pitch-data
ty-porter May 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<!-- Before submitting a new issue, check that it is not already solved! (https://github.com/MLB-LED-Scoreboard/mlb-led-scoreboard/issues?q=is%3Aissue) -->

## This issue is a

- [ ] Bug Report
- [ ] Feature Request

<!-- Filling out your complete hardware and software configuration is more likely to help project maintainers resolve your issue. You may omit configuration sections as needed if you are submitting a feature request. -->

## Hardware Configuration

- Raspberry Pi Revision (4B+/3B+/Zero/etc.):
- Operating System:
- Matrix size:
- Display adapter (HAT/Bonnet/etc.):
- Additional information:
- Power source(s):

<!-- Additional display adapter information could include E-address line mod, GPIO 4/18 performance mod, etc. Omit this section if you are unsure. -->

## Software Configuration

<!-- Scoreboard version can be found by running `python version.py` from the project directory. -->

- MLB LED Scoreboard Version:
- Commands/arguments used to start the scoreboard:

## Expected behavior
<!-- What should happen? -->

## Actual behavior
<!-- What happens instead? -->

## Additional Information
<!-- If you have a specific error message or code, PLEASE post with your issue so project maintainers can easily diagnose the problem. -->
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# mlb-led-scoreboard [![Join Slack](https://img.shields.io/badge/slack-join-blue.svg)](https://mlb-led-scoreboard.herokuapp.com/)
# mlb-led-scoreboard
![Current Version](https://img.shields.io/github/v/release/MLB-LED-Scoreboard/MLB-LED-Scoreboard) [![Join Slack](https://img.shields.io/badge/slack-join-blue.svg)](https://mlb-led-scoreboard.herokuapp.com/)

---------------

Expand Down Expand Up @@ -104,6 +105,12 @@ It will also install the following python libraries that are required for certai

That should be it! Your latest version should now be working with whatever new fangled features were just added.

#### Version Information

You can check the version information for your installation of mlb-led-scoreboard by running `python3 version.py`.

The latest version of the software is available [here](https://github.com/MLB-LED-Scoreboard/mlb-led-scoreboard/releases).

#### Time Zones
Make sure your Raspberry Pi's timezone is configured to your local time zone. They'll often have London time on them by default. You can change the timezone of your raspberry pi by running `sudo raspi-config`.

Expand Down Expand Up @@ -161,6 +168,7 @@ A default `config.json.example` file is included for reference. Copy this file t
"time_format" String Sets the preferred hour format for displaying time. Accepted values are "12h" or "24h" depending on which you prefer.
"end_of_day" String A 24-hour time you wish to consider the end of the previous day before starting to display the current day's games. Uses local time from your pi.
"full_team_names" Bool If true and on a 64-wide board, displays the full team name on the scoreboard instead of their abbreviation. This config option is ignored on 32-wide boards. Defaults to true when on a 64-wide board.
"short_team_names_for_runs_hits" Bool If true and full_team_names is true and Runs Hits Errors is enabled, will use abreviated team names when Runs or Hits > 9
"scrolling_speed" Integer Supports an integer between 0 and 4. Sets how fast the scrolling text scrolls.
"debug" Bool Game and other debug data is written to your console.
"demo_date" String A date in the format YYYY-MM-DD from which to pull data to demonstrate the scoreboard. A value of `false` will disable demo mode.
Expand All @@ -169,6 +177,8 @@ A default `config.json.example` file is included for reference. Copy this file t
### Additional Features
* Runs/Hits/Errors - Runs are always shown on the games screen, but you can enable or adjust spacing of a "runs, hits, errors" display. Take a look at the [coordinates readme file](/coordinates/README.md) for details.

* Pitch Data - Pitch data can be shown on the game screen, See the [coordinates readme file](/coordinates/README.md) for details. In addition, the Short and Long pitch description can be changed in data/pitches.py

### Flags

You can configure your LED matrix with the same flags used in the [rpi-rgb-led-matrix](https://github.com/hzeller/rpi-rgb-led-matrix) library. More information on these arguments can be found in the library documentation.
Expand Down
5 changes: 5 additions & 0 deletions colors/scoreboard.json.example
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@
"g": 235,
"b": 59
},
"pitch": {
"r": 255,
"g": 255,
"b": 255
},
"strikeout": {
"r": 255,
"g": 235,
Expand Down
2 changes: 2 additions & 0 deletions config.json.example
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
"time_format": "12h",
"end_of_day": "00:00",
"full_team_names": true,
"short_team_names_for_runs_hits": true,
"pregame_weather": true,
"scrolling_speed": 2,
"debug": false,
"demo_date": false
Expand Down
5 changes: 5 additions & 0 deletions coordinates/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ The layout can have a couple of different states where things are rendered diffe
* `compress_digits` will reduce the space between digits when the number of runs or hits is > 9.
* `spacing` is the number of pixels between the runs/hits and hits/errors.

## Pitch Data
* enabled (true/false) turn feature on/off
* mph (true/false) When rendering pitch speed add mph after (99 mph)
* desc_length (Short/Long) The short or long pitch type description, you can change both the short and long description to your liking in data/pitches as long as you do not change the index value.

## Updates
The software develops and releases features with full support for the default layouts, so custom layouts may look unsatisfactory if you update to later versions of the scoreboard. If you as a user decide to create a custom layout file, you are responsible for tweaking the coordinates to your liking with each update.

Expand Down
9 changes: 9 additions & 0 deletions coordinates/w128h32.json.example
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@
"y": 30,
"width": 40
},
"pitch": {
"font_name": "4x6",
"x": 1,
"y": 50,
"width": 41,
"enabled": false,
"mph": false,
"desc_length": "Short"
},
"loop": 64,
"strikeout": {
"x": 84,
Expand Down
91 changes: 52 additions & 39 deletions coordinates/w128h64.json.example
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
{
"defaults": {
"font_name": "9x18B"
"font_name": "7x13"
},
"bases": {
"1B": {
"x": 112,
"y": 42,
"size": 14
"size": 10
},
"2B": {
"x": 103,
"y": 33,
"size": 14
"size": 10
},
"3B": {
"x": 94,
"y": 42,
"size": 14
"size": 10
}
},
"final": {
Expand Down Expand Up @@ -46,7 +46,7 @@
},
"due_up": {
"due": {
"font_name": "7x13B",
"font_name": "5x7",
"x": 38,
"y": 44
},
Expand All @@ -55,13 +55,13 @@
"y": 56
},
"divider": {
"draw": true,
"draw": false,
"x": 36,
"y_start": 32,
"y_end": 64
},
"leadoff": {
"font_name": "7x13B",
"font_name": "7x13",
"x": 64,
"y": 42
},
Expand All @@ -76,8 +76,8 @@
}
},
"number": {
"x": 93,
"y": 45,
"x": 87,
"y": 42,
"nohit": {
"x": 93,
"y": 42
Expand All @@ -88,46 +88,55 @@
}
},
"arrow": {
"size": 7,
"size": 6,
"up": {
"x_offset": -12,
"y_offset": -10
"x_offset": -11,
"y_offset": -8
},
"down": {
"x_offset": -12,
"y_offset": -2
"x_offset": -11,
"y_offset": -4
}
}
},
"outs": {
"1": {
"x": 102,
"y": 58,
"size": 4
"x": 95,
"y": 56,
"size": 5
},
"2": {
"x": 108,
"y": 58,
"size": 4
"x": 106,
"y": 56,
"size": 5
},
"3": {
"x": 114,
"y": 58,
"size": 4
"x": 118,
"y": 56,
"size": 5
}
},
"atbat": {
"batter": {
"font_name": "7x13B",
"font_name": "5x7",
"x": 1,
"y": 60,
"width": 41
},
"pitcher": {
"font_name": "7x13B",
"font_name": "5x7",
"x": 1,
"y": 44,
"width": 48
"y": 40,
"width": 41
},
"pitch": {
"font_name": "4x6",
"x": 1,
"y": 50,
"width": 41,
"enabled": true,
"mph": true,
"desc_length": "Long"
},
"loop": 68,
"strikeout": {
Expand All @@ -137,7 +146,7 @@
},
"batter_count": {
"x": 66,
"y": 60,
"y": 62,
"nohit": {
"x": 66,
"y": 64
Expand Down Expand Up @@ -246,27 +255,31 @@
},
"name": {
"away": {
"font_name": "9x18B",
"x": 4,
"y": 12
"y": 13
},
"home": {
"font_name": "9x18B",
"x": 4,
"y": 28
"y": 29
}
},
"runs": {
"runs_hits_errors": {
"show": false,
"compress_digits": false,
"spacing": 3
},
"show": true,
"compress_digits": true,
"spacing": 5
},
"away": {
"x": 120,
"y": 12
"font_name": "9x18B",
"x": 126,
"y": 13
},
"home": {
"x": 120,
"y": 28
"font_name": "9x18B",
"x": 126,
"y": 29
}
}
},
Expand Down Expand Up @@ -321,4 +334,4 @@
"y": 31
}
}
}
}
9 changes: 9 additions & 0 deletions coordinates/w32h32.json.example
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,15 @@
"y": 33,
"width": 12
},
"pitch": {
"font_name": "4x6",
"x": 1,
"y": 50,
"width": 41,
"enabled": false,
"mph": false,
"desc_length": "Short"
},
"loop": 16,
"strikeout": {
"x": 33,
Expand Down
9 changes: 9 additions & 0 deletions coordinates/w64h32.json.example
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,15 @@
"y": 21,
"width": 24
},
"pitch": {
"font_name": "4x6",
"x": 1,
"y": 50,
"width": 41,
"enabled": false,
"mph": false,
"desc_length": "Short"
},
"loop": 36,
"strikeout": {
"x": 15,
Expand Down
9 changes: 9 additions & 0 deletions coordinates/w64h64.json.example
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,15 @@
"y": 28,
"width": 50
},
"pitch": {
"font_name": "4x6",
"x": 1,
"y": 50,
"width": 41,
"enabled": false,
"mph": false,
"desc_length": "Short"
},
"loop": 64,
"strikeout": {
"x": 31,
Expand Down
2 changes: 2 additions & 0 deletions data/config/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ def __init__(self, filename_base, width, height):
self.time_format = json["time_format"]
self.end_of_day = json["end_of_day"]
self.full_team_names = json["full_team_names"]
self.short_team_names_for_runs_hits = json["short_team_names_for_runs_hits"]
self.pregame_weather = json["pregame_weather"]
self.debug = json["debug"]
self.demo_date = json["demo_date"]
# Make sure the scrolling speed setting is in range so we don't crash
Expand Down
Loading