Skip to content

Conversation

@djanelle-mit
Copy link

@djanelle-mit djanelle-mit commented Oct 20, 2025

Developer

We had a request to remove all news stories (across all post types) older than July 1, 2021. To explore this, we added this plugin to a multidev to experiment with it's functionality. We found the results satisfactory, and would like to move it to production.

This work introduces the wp_bulk_delete plugin to our Wordpress site.

Stylesheets

  • Any theme or plugin whose stylesheets have changed has had its version
    string incremented.

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

YES | NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the issue. The CI check we run (which is meant to check our locally-writen code for adherence to code standards) is finding the plugin contents. The things being flagged aren't an issue, they're stylistic, and we're comfortable not worrying about style issues in other people's code.

The change that's needed is that we need to add this new plugin to the ignore list in phpcs.xml in the repository root. You'll see a big long list of other plugins that we ignore in this way, wrapped up in <exclude-pattern> tags. The plugins go in alphabetical order to make maintenance easier, so you'll probably want to add an ignore for this plugin too, around line 78.

Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I didn't confirm what the plugin does, I'm trusting you worked that out with Darcy and have no concerns. From a code perspective, this all looks good - sorry I forgot about the ignore list when we talked last week.

Looking at the docs we maintain in this repo, we should probably have a how-to article about managing third-party code. It doesn't need to be part of this PR, and could just be a link to composer and wpackagist or something. I'll make a ticket in our backlog for this, I think.

@djanelle-mit djanelle-mit merged commit 515d353 into master Oct 20, 2025
3 checks passed
@djanelle-mit djanelle-mit deleted the news-test branch October 20, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants