Skip to content

Conversation

@djanelle-mit
Copy link

@djanelle-mit djanelle-mit commented Sep 26, 2025

Developer

As part of the work done to change the typeface from Open Sans to Neue Haas Grotesk, the underline to links in news stories was removed. Since no other affordance was added, it's impossible to tell at a glance that there are links to visit.

This work adds that underline back in.

Stylesheets

  • Any theme or plugin whose stylesheets have changed has had its version
    string incremented.

Secrets

  • All new secrets have been added to Pantheon tiers
  • Relevant secrets have been updated in Github Actions
  • All new secrets documented in README

Documentation

  • Project documentation has been updated
  • No documentation changes are needed

Accessibility

  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)

Stakeholder approval

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies

YES | NO dependencies are updated

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • The changes have been verified
  • The documentation has been updated or is unnecessary
  • New dependencies are appropriate or there were no changes

Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't bring myself to believe the line numbers being referenced here, so had to go look up the stylesheet in context. Yes, apparently this is actually the first rules that we define for the entire theme - link decoration styles, defined in a non-intuitive way.

I'm not going to block this, it will get the job done that we need to, but wow I really can't wait until we have a more rational stylesheet for this theme.

@djanelle-mit
Copy link
Author

@matt-bernhardt Absolutely... the entire news site's CSS is in dire need of a refactor! Hopefully a problem we can address in the near future.

@djanelle-mit djanelle-mit merged commit 796fd9c into master Sep 26, 2025
3 checks passed
@djanelle-mit djanelle-mit deleted the web-2192 branch September 26, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants