Skip to content

Commit ccfd4b5

Browse files
Ensure 'status_details' is cleared on success
Why these changes are being introduced: * Prior to this change, if a command failed and was rerun successfully, the error from the failed run remained in 'status_details'. This ensures 'status_details' is cleared by successful runs. How this addresses that need: * Set 'status_details' to None on success Side effects of this change: * None Relevant ticket(s): * None
1 parent d5a0dae commit ccfd4b5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

dsc/workflows/base/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ def _create_batch_in_db(self, item_submissions: list[dict]) -> None:
256256
item_submission = ItemSubmission.create(**item_submission_init_params)
257257
item_submission.last_run_date = self.run_date
258258
item_submission.status = ItemSubmissionStatus.BATCH_CREATED
259+
item_submission.status_details = None
259260
item_submission.save()
260261

261262
@final
@@ -454,11 +455,11 @@ def submit_items(self, collection_handle: str) -> list:
454455

455456
# Set status in DynamoDB
456457
item_submission.status = ItemSubmissionStatus.SUBMIT_SUCCESS
458+
item_submission.status_details = None
457459
item_submission.submit_attempts += 1
458460
item_submission.upsert_db()
459461
except Exception as exception: # noqa: BLE001
460462
self.submission_summary["errors"] += 1
461-
462463
item_submission.status = ItemSubmissionStatus.SUBMIT_FAILED
463464
item_submission.status_details = str(exception)
464465
item_submission.submit_attempts += 1
@@ -529,6 +530,7 @@ def finalize_items(self) -> None:
529530
# update item submission status based on ingest result
530531
if result_message.result_type == "success":
531532
item_submission.status = ItemSubmissionStatus.INGEST_SUCCESS
533+
item_submission.status_details = None
532534
item_submission.dspace_handle = result_message.dspace_handle
533535
sqs_results_summary["ingest_success"] += 1
534536
logger.debug(f"Record {log_str} was ingested")

0 commit comments

Comments
 (0)