example flag style propagation + minor corrections

[argonaut22]

Noting that the conversion of pari is near(ish), a consistent flag syntax would be ideal.

@speth suggested a convention of <verb>_<subject> like is_laminar or has_shaft for Boolean parameters, PLUS a string-based option selection for parameters that have more options (e.g icool can be opt_cooling which will be under engine). I would also vote to add a prefix for flags, e.g., flag_is_laminar, for ease of searching and identification in the codebase.

Thoughts/objections on this @everyone (@aditeyashukla @ngomezve @askprash )?
Making sure we all agree before trying to push beyond this sample HXfun.jl

[argonaut22]

Should we choose to proceed, here's a probably-not-but-maybe-comprehensive list of replacements on deck. all are booleans unless marked by *:

• HXfun.jl
• blsys for lam, wake, etc. all boolean
• cdsum: icdfun
• trefftz: Lspec
• balance: iiengloc, iiHTsize, iixwmove*
• tanksize: flag_size, flag_vacuum
• fuselage_tank: size_insulation
• tfan: icool*
• aircraft: sized (also see Improve sized flag logic #99)
• size_cabin: flag_aisle, fdoubledecker
• everything in pari

[argonaut22]

As an example for how the string comparison would work, the comparison could be:

if engine.opt_cooling == "none"
    ...
elseif engine.opt_cooling == "fixed_BPRc"
    ...
elseif engine.opt_cooling == "fixed_Tmetal"
    ...
end

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (430cfd8) to head (3bb98d1).
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   73.41%   73.19%   -0.23%     
==========================================
  Files          77       80       +3     
  Lines       13908    13459     -449     
==========================================
- Hits        10211     9851     -360     
+ Misses       3697     3608      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[askprash]

This is good, we should do this! Personally, I'm not sure we need the flag_ prefix - just makes it longer, and there's something nice about reading if is_laminar in the code but not a strong opposition. For the option string variables though having the opt prefix seems nice.

Also for the string variables it would be good to lowercase() everything while testing to be consistent.

[argonaut22]

Consensus is flag_ not needed. Will incorporate the changes above in the next few days

[askprash]

@argonaut22 is this one we can sort out for the release? It should also help get rid of some flags inside pari.