Removing overconstraints in off-design aircraft #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses Issue #133 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 79.13% 79.14%
=======================================
Files 82 82
Lines 13575 13585 +10
=======================================
+ Hits 10743 10752 +9
- Misses 2832 2833 +1 ☔ View full report in Codecov by Sentry. |
simplified atmos docs
askprash
reviewed
Feb 20, 2025
askprash
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TASOPT aircraft were analyzed off-design in$L \neq W$ . This PR changes
fly_off_design!, the user was free to independently set the Mach number, altitude, and lift coefficient at cruise. In general, this leads tofly_off_design!so that the cruise altitude is calculated for a desired lift coefficient.