-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised landing gear models #128
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 79.13% 79.17% +0.03%
==========================================
Files 82 84 +2
Lines 13575 13639 +64
==========================================
+ Hits 10743 10798 +55
- Misses 2832 2841 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR, I think having more complexity in the landing gear models will help us a lot in the long run.
Also, the unpack_ac
function is super useful! I know you added it in the main places but we should do a sweep across the codebase and replace it where needed
This looks good, thanks @ngomezve ! Does it give reasonable length of landing gear for the default aircraft? That might be a useful check if we are in the right ballpark. The airport planning docs are a useful place to compare. Looks like for the A321 the main gear is a little under 3 m and the nose gear is about 1.4 m |
(Haven't reviewed the whole PR yet, but inb4 it gets merged) I think we're okay to remove the regional and wide regression tests, but I don't agree with binning the See below for less succinct discourse: |
@askprash For the default TASOPT aircraft (A320-like), I get a landing gear length of 1.17 m assuming a 7inch engine ground clearance. It looks like the A320 actually has a larger clearance. The model currently assumes the same length for main and nose gears, although the data structure allows for them to be different. I'll look if it's possible to make them be different without adding new parameters. |
If I add one extra parameter for the spanwise location of the main gear (needed anyways as not currently defined) and I change the ground clearance to 60 cm (more representative of the A321), I get a nose gear length of 1.58 m and a main gear length of 1.97 m. This is for the main gear being at 20% of the halfspan as is more or less the case in the A321. |
The one thing that I am not capturing is that the wing bottom plane doesn't have to intercept the bottom of the fuselage (usually it is further up and hence so is the main gear), but this is probably OK for now. |
increased default widebody clearance
This PR, which supersedes #107, introduces new landing gear mass models based on historical correlations. In the future, physics-based models could be included as well. The following changes are made:
-Two landing gear models are supported: the previous constant mass fractions and a model based on historical data, which incorporates dependencies on landing gear length and design.
-The landing gear parameters are stored in a new object in
ac
. The relatedparg
parameters are eliminated.-Documentation and tests for the landing gear models.