Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuselage fuel tank cleanup #119

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fuselage fuel tank cleanup #119

wants to merge 11 commits into from

Conversation

ngomezve
Copy link
Contributor

This PR simplifies the structure of the code used to size and calculate the weight of fuel tanks in the fuselage. The previous code retained functionality that is no longer needed (e.g., calculating constant boiloffs when now there is a dedicated boiloff model) and was more cumbersome than it needs to be.

The PR moves some pieces of code from wsize() to tank_size() and update_fuse!() and also changes the inputs of these functions so that they only need the ac object.

The changes introduced in the PR are to the code structure only and should not change the underlying models.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 92.98246% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (e182855) to head (a5d9106).

Files with missing lines Patch % Lines
src/cryo_tank/tanksize.jl 90.56% 5 Missing ⚠️
src/cryo_tank/tanktools.jl 33.33% 2 Missing ⚠️
src/structures/update_fuse.jl 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   79.14%   79.17%   +0.02%     
==========================================
  Files          82       82              
  Lines       13585    13597      +12     
==========================================
+ Hits        10752    10765      +13     
+ Misses       2833     2832       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve ngomezve marked this pull request as ready for review February 11, 2025 19:59
Copy link
Contributor

@aditeyashukla aditeyashukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think the reduction in wsize is quite clean. I think maybe @argonaut22 can look into the flags for the tank position when he fixes the pari flags like iifwing (although I cant think of anything better than the strings we have right now).
Maybe if you want to be safe we can do lowercase(tank_placement)

@ngomezve
Copy link
Contributor Author

ngomezve commented Feb 18, 2025

This commit fixes a bug in which the tank sea level temperature was not being updated in off-design. It also fixes a minor bug if the aircraft is a double-decker: the issue was in update_fuse_for_pax, which did not store one output. The inputs for this function have also been simplified.

@ngomezve ngomezve added the enhancement New feature or request label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants