-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuselage fuel tank cleanup #119
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 79.14% 79.17% +0.02%
==========================================
Files 82 82
Lines 13585 13597 +12
==========================================
+ Hits 10752 10765 +13
+ Misses 2833 2832 -1 ☔ View full report in Codecov by Sentry. |
back to default in PRD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think the reduction in wsize is quite clean. I think maybe @argonaut22 can look into the flags for the tank position when he fixes the pari flags like iifwing
(although I cant think of anything better than the strings we have right now).
Maybe if you want to be safe we can do lowercase(tank_placement)
fixed test error
This commit fixes a bug in which the tank sea level temperature was not being updated in off-design. It also fixes a minor bug if the aircraft is a double-decker: the issue was in |
This PR simplifies the structure of the code used to size and calculate the weight of fuel tanks in the fuselage. The previous code retained functionality that is no longer needed (e.g., calculating constant boiloffs when now there is a dedicated boiloff model) and was more cumbersome than it needs to be.
The PR moves some pieces of code from
wsize()
totank_size()
andupdate_fuse!()
and also changes the inputs of these functions so that they only need theac
object.The changes introduced in the PR are to the code structure only and should not change the underlying models.