Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SimpleITK to 2.0.2, maintain list of packages only in requirements.txt #57

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Set SimpleITK to 2.0.2, maintain list of packages only in requirements.txt #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27fddb5
let setup.py parse requirements.txt
tashrifbillah Oct 29, 2021
675bbbf
Merge pull request #1 from pnlbwh/parse-requirements
tashrifbillah Jun 3, 2024
b13190b
Merge pull request #2 from MIC-DKFZ/master
tashrifbillah Jun 4, 2024
a68d1fa
set SimpleITK==2.0.2
tashrifbillah Jun 4, 2024
d1e22da
this line was syntactically wrong, we do not need it anyway
tashrifbillah Jun 4, 2024
c26ef0f
split requirements.txt line by newline character
tashrifbillah Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
numpy>=1.14.5
torch>=0.4.0
scikit-image>=0.14.0
SimpleITK>=2.0.2
-e git+https://github.com/MIC-DKFZ/batchgenerators#egg=batchgenerators
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was syntactically incorrect. We do not need it anyway because this function has been copied over:

HD-BET/HD_BET/data_loading.py

Line 98 in ae16068

def resize_segmentation(segmentation, new_shape, order=3, cval=0):

SimpleITK==2.0.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft version specification no longer works because of progress of SimpleITK ever since. So I did hard specification.

9 changes: 3 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
from setuptools import setup, find_packages

requirements= open('requirements.txt').read().split('\n')

setup(name='HD_BET',
version='1.0',
description='Tool for brain extraction',
Expand All @@ -9,12 +11,7 @@
author_email='[email protected]',
license='Apache 2.0',
zip_safe=False,
install_requires=[
'numpy',
'torch>=0.4.1',
'scikit-image',
'SimpleITK'
],
install_requires=requirements,
scripts=['HD_BET/hd-bet'],
packages=find_packages(include=['HD_BET']),
classifiers=[
Expand Down