Fixed string.format with substrings

MCJack123 · Oct 31, 2021 · fe82e7d · fe82e7d
1 parent 0a4bfb8
commit fe82e7d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/lapi.c b/src/lapi.c
@@ -350,12 +350,13 @@ LUA_API int lua_toboolean (lua_State *L, int idx) {
 
 LUA_API const char *lua_tolstring (lua_State *L, int idx, size_t *len) {
   StkId o = index2adr(L, idx);
-  if (ttissubstr(o) && len != NULL) {
-    /* if using lua_tostring, we need to convert to normal string so the cstring ends with \0 */
-    /* otherwise, we can keep the substring intact */
+  /*if (ttissubstr(o) && len != NULL) {
+    / * ~~if using lua_tostring, we need to convert to normal string so the cstring ends with \0 * /
+    / * otherwise, we can keep the substring intact~~ * /
+    / * EDIT: this breaks Lua spec - we're always doing this * /
     *len = ssvalue(o)->len;
     return getstr(ssvalue(o)->str) + ssvalue(o)->offset;
-  }
+  }*/
   if (!ttisstring(o)) {
     lua_lock(L);  /* `luaV_tostring' may create a new string */
     if (!luaV_tostring(L, o)) {  /* conversion failed? */

diff --git a/src/lstrlib.c b/src/lstrlib.c
@@ -850,7 +850,7 @@ static int str_format (lua_State *L) {
             continue;  /* skip the `addsize' at the end */
           }
           else {
-            sprintf(buff, form, s);
+            snprintf(buff, MAX_ITEM, form, s);
             lua_pop(L, 1);
             break;
           }