-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional optimization passes and rework I/O considerations #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #120.
Adds two new optimization passes, gives finer control over what MCHPRS considers to be inputs/outputs and some QoL changes to commands.
Hope the huge scope of this PR is acceptable, as it was too difficult to properly decouple everything and create separate PR's for each change.
Changes:
/toggleioonly
command that ensures only I/O blocks are visually updated, even in "development mode" (without active redpiler)Buffer
component that can be used to coalesce multiple componentsPruneOrphans
pass, removes all nodes that do not contribute to output componentsTailCoalesce
pass, replaces lines of comparators, that only connect to outputs, with the newBuffer
componentAdds a playground crate to to run experiments (Should possibly be removed or better commented?)Checks:
Node
in direct.rs now contains exactly 128 bytesOpen improvements and considerations:
Node
ever needs to hold more stateImprove documentation on the new "magic" build script?tail_coalesce
pass can theoretically optimize more cases according to the results of the playgrounds experiments