-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-606-Review-4 #449
base: GH-606-Review-4
Are you sure you want to change the base?
GH-606-Review-4 #449
Commits on Apr 24, 2024
-
GH-783 Fix tests failing on non standard environment (#432)
* fixed tests failing on Bert's computer * formatting * remove commented out code * change .clone() to reference * fixed test for windows in actions: tilde_in_config_file_path_from_commandline_and_args_uploaded_from_config_file * target_os for dirs crate used only on windows test * implementing Bert's review comments - change DirsWrapperMock to DirsWrapperReal and simplifying home_dir creation * fixing windows data-directory assertion in test tilde_in_config_file_path_from_commandline_and_args_uploaded_from_config_file * fixing home dir assertion for windows * add condition to use of dirs crate only for windows * fixing config toml for windows test tilde_in_config_file_path_from_commandline_and_args_uploaded_from_config_file * fixed windows test * formatting * fixed tilde tests for windows * remove unnecesary function for finding project root, use of current dir for DirsWrapperMock * adjusting name of test and removing commented out code
Configuration menu - View commit details
-
Copy full SHA for 6047a13 - Browse repository at this point
Copy the full SHA 6047a13View commit details
Commits on May 21, 2024
-
GH-791: Small fixes to stabilize tests in setup_reporter.rs (#443)
* GH-791: fixed * GH-791: put some explanatory lines back --------- Co-authored-by: Bert <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55851fc - Browse repository at this point
Copy the full SHA 55851fcView commit details
Commits on May 29, 2024
-
GH-797: Update min-hops command docs in User Interface (#447)
* GH-797: minor docs modification * GH-797: some TODOs * GH-797: add the definitions for min hops and gas price. * GH-797: remove the markdown code container
Configuration menu - View commit details
-
Copy full SHA for 40480d1 - Browse repository at this point
Copy the full SHA 40480d1View commit details -
GH-728: Finish the password-change logic (#355)
* GH-728: add the TODOs * GH-728: removed the code of the NewPasswordMessage * GH-728: use ConfigurationChangeMessage while changing password * GH-728: rename configuration_change_msg_sub_opt to update_min_hops_sub_opt * GH-728: rename new_password_subs to update_password_subs * GH-728: fix wrong name for the actor message * GH-728: send ConfigurationChangeMessage to other actors too * GH-728: add a TODO * GH-728: rename to _opt * GH-728: implement handler for ConfigurationChange::UpdatePassword inside Neighborhood * GH-728: add TODO to implement handler for ConfigurationChange::UpdatePassword inside BlockchainBridge * GH-728: add TODO to implement handler for ConfigurationChange::UpdatePassword inside Accountant * GH-728: create new struct for UpdatePasswordSubs * GH-728: add the new TODO * GH-728: send a ConfigurtionChangeMessage when the consuming wallet is generated * GH-728: add a test for the panic case * GH-728: some refactor changes in configurator.rs * GH-728: test drive the case when the wallet is recovered * GH-728: fix some of the tests * GH-728: fix the remaining 2 failing tests * GH-728: reorder fields * GH-728: the received ConfigurationChangeMessage is properly handled * GH-728: update the password when necessary * GH-728: add a todo * GH-728: add the ability to synchronise password * GH-728: add ability for accountant to handle an unexpected configuration change msg * GH-728: improve tests for handling ConfigurationChangeMessage in accountant * GH-728: minor renames * GH-728: remove finished TODO and formatting changes * GH-728: add test in blockchain bridge for ConfigurationChangeMessage * GH-728: add test in neighborhood for ConfigurationChangeMessage * GH-728: remove useless tests * GH-728: revive an old test * GH-728: improve todo * GH-728: test rename and add more TODOs * GH-728: cleanup and creation of new file configuration_change_subs.rs * GH-728: minor refactor and remove tests * GH-728: introduce trait for ConfigurationChangesubs * GH-728: refactor out the subs for UpdateWallets and UpdatePassword * GH-728: some renames * GH-728: add TODO and minor reordering * GH-728: make the test the_password_is_synchronised_among_other_actors_when_modified stronger * GH-728: add formatting changes * GH-728: make enum usage more explicit * GH-728: remove clippy warnings * GH-728: do some renames * GH-728: fix wrong rename and import * GH-728: use peer actors for generating config change subs * GH-728: recreate ConfigChangeSubs * GH-728: remove config_change_subs.rs * GH-728: test for ConfigChangeMsg in Accountant contain assertions * GH-728: test for ConfigChangeMsg in Neighborhood contain assertions * GH-728: test for ConfigChangeMsg in BlockchainBridge contain assertions * GH-728: small rename * GH-728: add context_id to fn * GH-728: refactor the fn to transform associated functions to methods * GH-728: minor fixes * GH-728: add wallet_opt as a new argument in the begin_scan fn * GH-728: remove the use of field consuming_wallet_opt from BlockchainBridge * GH-728: remove the field consuming_wallet_opt from BlockchainBridge * GH-728: don't send the ConfigChangeMsg to the BlockchainBridge * GH-728: use the earning wallet in Receivable Scanner's begin_scan * GH-728: don't save a reference of earning wallet inside Scanners * GH-728: store the earning wallet directly without an Rc * GH-728: fix the failing test * GH-728: formatting changes * GH-728: remove the earning wallet from ReceivableScannerBuilder * GH-728: check wallet in the begin_scan() for ScannerMock * GH-728: remove unnecessary TODO * GH-728: formatting changes * GH-728: fix the failing test * GH-728: remove unused import in blockchain_interaction_test.rs * GH-728: BlockchainBridge receives consuming_wallet instead of an Option<T> * GH-728: Check consuming wallet before sending a msg to BlockchainBridge * GH-728: remove Option<T> from the wallet_opt param in begin_scan fn * GH-728: remove commented out code * GH-728: modify AccountantBuilder to make it's field names contain opt * GH-728: improve test mocks * GH-728: introduce another URL for mumbai testnet * GH-728: change the message in trace log * GH-728: test drive the NoConsumingWallet Error * GH-728: reordering * GH-728: add better logging * GH-728: Review 2 changes * GH-728: Review 2 leftover changes * GH-728: add better assertions for logger
Configuration menu - View commit details
-
Copy full SHA for 2007ccd - Browse repository at this point
Copy the full SHA 2007ccdView commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 25e9a4f - Browse repository at this point
Copy the full SHA 25e9a4fView commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5039c3a - Browse repository at this point
Copy the full SHA 5039c3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf3877d - Browse repository at this point
Copy the full SHA bf3877dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 717b966 - Browse repository at this point
Copy the full SHA 717b966View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cbfd3a - Browse repository at this point
Copy the full SHA 5cbfd3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bcace5 - Browse repository at this point
Copy the full SHA 0bcace5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 105421b - Browse repository at this point
Copy the full SHA 105421bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bda6f39 - Browse repository at this point
Copy the full SHA bda6f39View commit details
Commits on Jul 15, 2024
-
GH-606: debugging test 'verify bill payment', added some little impro…
…vements
Bert authored and Bert committedJul 15, 2024 Configuration menu - View commit details
-
Copy full SHA for e108ef6 - Browse repository at this point
Copy the full SHA e108ef6View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 33bfc49 - Browse repository at this point
Copy the full SHA 33bfc49View commit details