Feature/email reminder #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created email form to send email to participants.
Codecov Report
@@ Coverage Diff @@
## dev #378 +/- ##
===========================================
- Coverage 83.25% 72.52% -10.73%
===========================================
Files 116 114 -2
Lines 3607 3531 -76
===========================================
- Hits 3003 2561 -442
- Misses 604 970 +366
Continue to review full report at Codecov.
|
# Conflicts: # news/forms.py # news/templates/news/admin_event_ticket_list.html # news/views.py
mahoyen
suggested changes
Oct 15, 2021
| {{ form.content }} | ||
| </div> | ||
| <input class="ui yellow right floated submit button" type="submit" value="{% trans "Send" %}"> | ||
| <a href="{% block cancel-url %}{% url "admin-event" form.instance.id %}{% endblock %}" class="ui red right floated button"> |
There was a problem hiding this comment.
Please add the name to the endblock and change the naming style as well.(relevant section)
Suggested change
| <a href="{% block cancel-url %}{% url "admin-event" form.instance.id %}{% endblock %}" class="ui red right floated button"> | |
| <a href="{% block cancel_url %}{% url "admin-event" form.instance.id %}{% endblock cancel_url %}" class="ui red right floated button"> |
Comment on lines
+83
to
+87
| if not event and not time_place: | ||
| raise forms.ValidationError("Event and timeplace cannot both be None.") | ||
| if event and time_place: | ||
| raise forms.ValidationError("Event and timeplace cannot both be set.") | ||
| return cleaned_data |
There was a problem hiding this comment.
It is nice if you have add tests that verify that the validation works as intended. I can help in a worksession if you'd like.
…ultiperiod.py Fieldname "multiperiod" in model ReservationRule renamed to "multi-period".
Co-authored-by: Markus Ho-Yen <[email protected]>
I'm not certain if this migration has a function or why it was created, but migration nr 21 depends on this one..
second attempt at fixing dependency.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented an email form for events. Allowing organizers to easily send email updates to everyone who signed up.