Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented get and set methods for TimePicker control on Android #231

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Implemented get and set methods for TimePicker control on Android #231

merged 1 commit into from
Aug 10, 2023

Conversation

OringelB
Copy link

@OringelB OringelB commented Jul 11, 2023 •
edited
Loading

Resolves

Resolves #37

This pull request addresses the issues identified in the TimePicker class and improves its functionality and reliability.

PR checklist

  • Have Legerity sample tests been added or updated, run locally, and all pass
  • Have added or updated support for platform specific element wrappers been reflected in the Page Object Generator
  • Have code styling rules been run on all new source file changes
  • Have relevant articles in the docs been added or updated for all new source file changes
  • Have major breaking changes been made and are documented

Other information

This is my first contribution. Open for improvments and suggestions

@OringelB OringelB requested a review from a team as a code owner July 11, 2023 10:22
@jamesmcroft jamesmcroft merged commit 8f3126e into MADE-Apps:feature/37-android-timepicker-element Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmcroft jamesmcroft jamesmcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OringelB @jamesmcroft