Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Sep 21, 2025

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Sep 21, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

49 files out of 156 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ildyria ildyria changed the base branch from master to webshop/refine-backend September 21, 2025 15:34
@ildyria ildyria force-pushed the webshop/refine-backend branch from 9e280aa to cf5e2bb Compare September 21, 2025 19:50
@ildyria ildyria force-pushed the webshop/refine-backend branch from cf5e2bb to 37c1301 Compare September 21, 2025 20:22
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (d4fd794) to head (3e9d01f).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from webshop/refine-backend to webshop/backend September 29, 2025 11:53
Base automatically changed from webshop/backend to master September 29, 2025 15:33
@ildyria ildyria force-pushed the webshop/frontend branch 2 times, most recently from 2dead19 to c39a2a4 Compare October 5, 2025 12:25
@ildyria ildyria changed the base branch from master to webshop/backend-more November 17, 2025 18:16
@ildyria ildyria marked this pull request as ready for review November 26, 2025 21:48
@ildyria ildyria requested a review from a team as a code owner November 26, 2025 21:48
@ildyria
Copy link
Member Author

ildyria commented Nov 26, 2025

@coderabbitai do your thing.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

@ildyria: I'll review the changes in this pull request right away!

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ildyria
Copy link
Member Author

ildyria commented Nov 26, 2025

@coderabbitai
Do not review the lang files.

@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Tip

For best results, initiate chat on the files or code changes.

@ildyria: Understood! I will not review the lang files in this pull request or future reviews. The language files will be excluded from my analysis.


✏️ Learnings added
Learnt from: ildyria
URL: https://github.com/LycheeOrg/Lychee/pull/3704

Timestamp: 2025-11-26T21:50:26.664Z
Learning: In the LycheeOrg/Lychee repository, lang/* files should not be reviewed at all. These files should be completely excluded from code review.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


🧠 Learnings used
Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3641
File: lang/no/settings.php:9-9
Timestamp: 2025-08-22T06:11:18.329Z
Learning: For lang/* translation files in the Lychee project: only review PHP-related issues (syntax, structure, etc.), not translation content, grammar, or language-related nitpicks. The maintainer ildyria has explicitly requested this approach.

Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3654
File: lang/es/gallery.php:210-210
Timestamp: 2025-08-27T08:48:45.672Z
Learning: The project maintainer ildyria has indicated that language localization consistency is not a priority ("Lang = don't care"), meaning English text in non-English language files is acceptable and should not be flagged as an issue.

Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3654
File: lang/cz/gallery.php:210-210
Timestamp: 2025-08-27T08:48:27.520Z
Learning: For this Lychee project, the maintainer prefers to keep language strings in English across all locale files rather than translating them to local languages.

Learnt from: ildyria
Repo: LycheeOrg/Lychee PR: 3637
File: lang/nl/renamer.php:10-94
Timestamp: 2025-08-20T20:35:04.474Z
Learning: In Lychee, translation files are initially created with English strings as placeholders, and actual translations are handled through Weblate (a web-based translation management system). This means finding English text in non-English locale files (like lang/nl/, lang/de/, etc.) is expected and part of their translation workflow, not an issue to flag.

@ildyria ildyria closed this Nov 26, 2025
@ildyria ildyria deleted the webshop/frontend branch November 26, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants