fix: improve lint

LushWay · Aug 27, 2024 · 7a03350 · 7a03350
1 parent 10b57bc
commit 7a03350
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 23 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -43,6 +43,7 @@ export default ts.config(
       '@typescript-eslint/no-unsafe-enum-comparison': 'off',
       '@typescript-eslint/no-misused-promises': 'off',
       '@typescript-eslint/no-unused-expressions': 'off',
+      '@typescript-eslint/class-literal-property-style': 'off',
       '@typescript-eslint/naming-convention': [
         'warn',
         {

diff --git a/src/lib/database/properties.ts b/src/lib/database/properties.ts
@@ -87,7 +87,6 @@ if (!__VITEST__)
 
     tables: DynamicPropertyDB.tables,
     getRawTableData(tableId) {
-      // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
-      return world.getDynamicProperty(tableId) + ''
+      return `${world.getDynamicProperty(tableId)}`
     },
   })
diff --git a/src/lib/extensions/enviroment.ts b/src/lib/extensions/enviroment.ts
@@ -181,8 +181,9 @@ expand(console, {
 globalThis.verbose = false
 
 Object.entriesStringKeys(MinecraftEntityTypes).forEach(([k, v]) => {
-  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-  // @ts-expect-error
+  if (v.includes(':')) return
+
+  // @ts-expect-error We force add prefix because WHY IT DOES NOT HAVE ONE
   MinecraftEntityTypes[k] = 'minecraft:' + v
 })
 
@@ -195,7 +196,13 @@ declare global {
      */
     format(seconds?: boolean): string
 
-    /** Converts date to format DD-MM-YYYY */
+    /**
+     * Converts date to format DD-MM-YYYY
+     *
+     * @example
+     *   const date = new Date()
+     *   date.toYYYYMMDD() 2024-12-04
+     */
     toYYYYMMDD(): string
 
     /**
@@ -216,7 +223,9 @@ Date.prototype.toYYYYMMDD = function () {
 Date.prototype.toHHMM = function () {
   const date = new Date(this)
   date.setHours(date.getHours() + 3)
-  return date.getHours().toString().padStart(2, '0') + ':' + date.getMinutes().toString().padStart(2, '0')
+  const hours = date.getHours().toString().padStart(2, '0')
+  const minutes = date.getMinutes().toString().padStart(2, '0')
+  return hours + ':' + minutes
 }
 
 Date.prototype.format = function () {

diff --git a/src/lib/rpg/loot-table.ts b/src/lib/rpg/loot-table.ts
@@ -1,5 +1,5 @@
 import { Container, EnchantmentType, ItemLockMode, ItemStack, system } from '@minecraft/server'
-import { MinecraftEnchantmentTypes, MinecraftItemTypes } from '@minecraft/vanilla-data'
+import { MinecraftEnchantmentTypes, MinecraftItemTypes, MinecraftItemTypesUnion } from '@minecraft/vanilla-data'
 import { Command } from 'lib/command'
 import { EventSignal } from 'lib/event-signal'
 import { inspect, isKeyof } from 'lib/util'
@@ -66,23 +66,14 @@ export class Loot {
    *
    * @param type Keyof MinecraftItemTypes
    */
-  item(type: Exclude<keyof typeof MinecraftItemTypes, 'prototype' | 'string'>): this
+  item(type: MinecraftItemTypesUnion): this
 
   /**
-   * Creates new item entry
+   * Creates new item entry from string type id
    *
-   * @param type Type of the item
+   * @param type String type id
    */
-  // eslint-disable-next-line @typescript-eslint/unified-signatures
-  item(type: string): this
-
-  /**
-   * Creates new item entry
-   *
-   * @param type Type of the item
-   */
-  // eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
-  item(type: string | Exclude<keyof typeof MinecraftItemTypes, 'prototype' | 'string'>) {
+  item(type: string) {
     if (isKeyof(type, MinecraftItemTypes)) type = MinecraftItemTypes[type]
     this.create(new ItemStack(type))
 

diff --git a/src/lib/shop/cost/cost.ts b/src/lib/shop/cost/cost.ts
@@ -17,7 +17,6 @@ export abstract class Cost<T = unknown> {
     return CostType.Action
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-literal-property-style
   get multiline(): boolean {
     return false
   }

diff --git a/src/modules/places/minearea/minearea-region.ts b/src/modules/places/minearea/minearea-region.ts
@@ -40,7 +40,6 @@ export class MineareaRegion extends RegionWithStructure {
     return true
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-literal-property-style
   get displayName() {
     return '§7Зона добычи'
   }

diff --git a/src/modules/places/mineshaft/mineshaft-region.ts b/src/modules/places/mineshaft/mineshaft-region.ts
@@ -41,7 +41,6 @@ export class MineshaftRegion extends MineareaRegion {
     return true
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-literal-property-style
   get displayName() {
     return '§7Шахта'
   }