Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper handling for vkCmdExecuteGeneratedCommandsEXT in the dump resources codepath #1777

Open
nickdriscoll-lunarg opened this issue Sep 30, 2024 · 0 comments
Assignees
Labels
P1 Prevents an important capture from being replayed replay Issue with replay (capture was successful) vulkan

Comments

@nickdriscoll-lunarg
Copy link
Contributor

The generated code for vkCmdExecuteGeneratedCommandsEXT is insufficient, as it will issue some Draw/Dispatch/TraceRays commands that will require special handling just like the normal function calls for Draw/Dispatch/TraceRays.

Need to add an override to vulkan_replay_dump_resources.cpp to determine which type of commands are being issued, and then do the necessary handling for that type.

@nickdriscoll-lunarg nickdriscoll-lunarg self-assigned this Sep 30, 2024
@bradgrantham-lunarg bradgrantham-lunarg added P1 Prevents an important capture from being replayed vulkan replay Issue with replay (capture was successful) labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Prevents an important capture from being replayed replay Issue with replay (capture was successful) vulkan
Projects
None yet
Development

No branches or pull requests

2 participants