Try to avoid 'Unable to add newly converted phar... to the list of ph… #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ars, a phar with that name already exists' due to https://bugs.php.net/bug.php\?id\=75101 [skip ci]
|
@beto-aveiga would this be related to any of these issues, just so we associate this with an issue that we're tracking. |
| @@ -206,7 +206,7 @@ protected function installBinary($binary, $version, $url, $sha, $hashalgo = 'sha | |||
| else { | |||
| $cacheFolder = sys_get_temp_dir() . \DIRECTORY_SEPARATOR . $binary . \DIRECTORY_SEPARATOR . $version; | |||
| } | |||
| $cacheDestination = $cacheFolder . \DIRECTORY_SEPARATOR . $fileName; | |||
| $cacheDestination = $cacheFolder. \DIRECTORY_SEPARATOR . bin2hex(random_bytes(5)) . $fileName; | |||
There was a problem hiding this comment.
Won't this mean we effectively invalidate the cache every time, and never use it?
There was a problem hiding this comment.
Yes. I had to do this because there was an error building Tugboat.
This error happened while running the composer install.
I couldn't find any other way.
There was a problem hiding this comment.
Would it make sense to only do the random string cache file after we recognize the error that is causing us to do this. This way we still get the benefits of cache for instances where everything is working fine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ars, a phar with that name already exists' due to https://bugs.php.net/bug.php\?id\=75101 [skip ci]