WIP Renovate/php 8.x luisaveiga #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| "psr-4": {"Lullabot\\DrainpipeDev\\Tests\\Functional\\": "tests/src/functional/"} | |||
| }, | |||
| "require": { | |||
| "php": "^8.1", | |||
| "php": "^8.3.8", | |||
There was a problem hiding this comment.
We're going to want to support PHP 8.1, 8.2, and 8.3.
There was a problem hiding this comment.
I'm unclear about what to do next.
If I don't change the PHP version, it won't work.
Do you have a suggestion on how to do it? My approach may be wrong.
|
@deviantintegral @justafish Is Drainpipe able to support multiple point releases of PHP? I thought it supported 8.1 and 8.2 right now, but I could be wrong. Suggestions on how we can support 8.1, 8.2, and 8.3? |
|
Fixed in main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a modification of #588
Background
The tugboat is not working. If I recall correctly, I saw a quota issue explaining why the tests are failing.
Do you know if this is what is needed? I added restrictions to run tests with PHP 8.3 only.
I also set the default DDEV version to 1.23.2 because I couldn't replicate the issues on my machine when I started. DDEV v1.23.2 already has PHP 8.3.
There are PHP version strings on the Drainpipe Tugboat still, but I prefer to first have feedback if this is the correct approach. If so, I can update the missing ones.