Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #310

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

luigimannoni
Copy link

Adds php 8 compatibility as asked on #302 also solves some waterfall problem on other libraries requiring different forks of the querypath/querypath library.

@Berdir
Copy link
Contributor

Berdir commented Dec 8, 2022

arthurkushman/querypath seems to be abandonded as well now, see arthurkushman/querypath#12.

To use this in a project, you can do composer require gravitypdf/querypath in a project and it should replace the others.

@luigimannoni
Copy link
Author

luigimannoni commented Dec 8, 2022

I've required the new 8.1 package directly on this PR, I'll push a release on packagist with the replace directive as well for this package

@luigimannoni
Copy link
Author

Published on https://packagist.org/packages/deimosindustries/lullabot-amp
Run composer require deimosindustries/lullabot-amp if you're using a project that requires this package (eg: drupal/amp)

@luigimannoni luigimannoni changed the title Feature/302 php8 compatibility PHP 8.1 compatibility Dec 8, 2022
@yesworld
Copy link

Any news.. ?

@luigimannoni
Copy link
Author

@yesworld no idea, sadly I am not a maintainer of this repo and I would need one of the owners to approve and merge the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants