Including form tags #203
Open
Including form tags #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bibislayer , Is the library now supports form tags also? |
|
@venkatesh-innoppl Yes integrated form validator. |
|
I have cloned the latest AMP library and when I use it on my Drupal site, still the form tags are removed from the HTML. Can you correct me if I am doing anything wrong? |
|
Lullabot haven't merged my pull request, you can create fork on your git and do this change on your fork |
|
Can you provide a patch for the changes you made? |
|
I have used the code changes from your commit and the form tag is not removed this time. But I am still facing few issues like amp form extension script is removed when verifying page source and action attribute on form tag is being removed. So could you please correct me if I am wrong? |
|
Can we merge this please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #151 bug, validator-generated.php file based on @AlvaroIT file.