Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup Makefile #975

Merged
merged 1 commit into from
Jul 15, 2024
Merged

cleanup Makefile #975

merged 1 commit into from
Jul 15, 2024

Conversation

rnpnr
Copy link
Contributor

@rnpnr rnpnr commented Dec 28, 2023

  • OS variable was unused
  • ifndef section is not needed since "make PREFIX=... MANPREFIX=..." overwrites whatever is set there
  • notdir is a GNU specific function (not POSIX) and doesn't do anything in this case
  • "sed -i" is not POSIX and pointless if pipes are used correctly
  • the "if" block can be removed since "sed" can also be used to copy files to the destination.

@rnpnr
cleanup Makefile
77647d1 
* OS variable was unused
* ifndef section is not needed since
  "make PREFIX=... MANPREFIX=..." overwrites
  whatever is set there
* notdir is a GNU specific function (not POSIX) and doesn't do
  anything in this case
* "sed -i" is not POSIX and pointless if pipes are used correctly
* the "if" block can be removed since "sed" can also be used to
  copy files to the destination.
@LukeSmithxyz LukeSmithxyz merged commit 0d9d2fe into LukeSmithxyz:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnpnr @LukeSmithxyz