Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement warnings on NeverClones that implement Copy #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

donmai-me
Copy link
Contributor

implements #393

@LukeMathWalker
Copy link
Owner

The implementation looks good!
Can you add a UI test for it?

You can use this one as a reference.
The test should live in this folder.

@LukeMathWalker LukeMathWalker added the waiting-for-author Can't make further progress without the issue author label Feb 15, 2025
@donmai-me
Copy link
Contributor Author

Are ui tests generated by a pavex command? I noticed that the name in a_warning_is_emitted_for_unused_constructors's cargo.toml is

[package]
name = "app_30248169"

Sorry if I missed a piece of documentation somewhere

@LukeMathWalker
Copy link
Owner

Not yet, although I should create a helper CLI to bootstrap them!
That's the hash of the crate. The way I usually go about it—name it "app_" and when you run cargo test it'll complain about missing a specific app_XXXXX, then I rename it to that 😅 Not the most polished, I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-author Can't make further progress without the issue author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants