Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #4

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Improve error handling #4

merged 4 commits into from
Apr 1, 2019

Commits on Apr 1, 2019

  1. Add more error types

    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    a8ad4b1 View commit details
    Browse the repository at this point in the history

  2. Rename StrategyError to BinsBuildError

    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    29f56f3 View commit details
    Browse the repository at this point in the history

  3. Make GridBuilder::from_array return Result 

    This is nice because it doesn't lose information. (Returning an
`Option` combines the two error variants into a single case.)
    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    bca2dc9 View commit details
    Browse the repository at this point in the history

  4. Make BinsBuildError enum non-exhaustive 

    Once the `#[non_exhaustive]` attribute is stable, we should replace
the hidden enum variant with that attribute on the enum.
    @jturner314
    jturner314 committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    f41b317 View commit details
    Browse the repository at this point in the history