Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent our own gsm.h from being shadowed #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 22, 2022

  1. Prevent our own gsm.h from being shadowed

    `libgsm` is typically installed with a top-level `gsm.h` include file
    (either as the main file or as a compatibility symlink to `gsm/gsm.h`).
    If `libgsm` is installed but `WITH_GSM` is disabled, it's possible that
    this copy will shadow our own when `audio/gsm/src` is being built,
    depending on how include directories are ordered.
    
    This will typically cause a build failure on systems such as FreeBSD,
    where `/usr/local/include` is inserted early in the list, such as seen
    in LubosD#305 (comment).
    
    (While both copies are almost identical, the original one enforces C
    linkage, which ours does not.)
    fbriere committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    b7af2e4 View commit details
    Browse the repository at this point in the history