Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Opus codec #179

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add support for the Opus codec #179

wants to merge 7 commits into from

Commits on Jun 9, 2022

  1. Extract the (optional) number of channels from the rtpmap codec name

    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    ed6a75b View commit details
    Browse the repository at this point in the history

  2. Reconstruct the parameters string in t_sdp::get_fmtp() 

    t_sdp::get_fmtp() previously assumed that any "a=fmtp:" line contained
only two tokens, but RFC 4566 does not preclude the presence of spaces
in the "format specific parameters" part.  In fact, there are many
examples (such as found in RFC 6871) where multiple parameters are
separated by "; ", thus creating several tokens.

The proper fix would probably be to introduce a `maxsplit` argument to
split_ws() in order to keep the whole string intact, but that would be a
bit intrusive.  Simply putting some spaces back to reconstruct the
string to a somewhat equivalent version will be enough for our needs.
    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    a108d74 View commit details
    Browse the repository at this point in the history

  3. Add t_sdp::set_fmtp_int_params(), to add several fmtp params at once

    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    4289d91 View commit details
    Browse the repository at this point in the history

  4. Make SDP format parameters available to any encoder/decoder

    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    5515b8c View commit details
    Browse the repository at this point in the history

  5. Add support for the Opus codec 

    Closes LubosD#101
    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b00f847 View commit details
    Browse the repository at this point in the history

  6. Don't use IMPORTED_TARGET for pkg_check_modules() in CMakeLists.txt 

    `IMPORTED_TARGET` was only introduced in CMake 3.6.
    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    60b9274 View commit details
    Browse the repository at this point in the history

  7. Remove the name of all <spacer> and <layout> elements 

    These generic names added by Qt Designer do nothing but cause conflicts.
    @fbriere
    fbriere committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    968db57 View commit details
    Browse the repository at this point in the history