feat: add hyprlua — LuaCATS annotations for Hyprland 0.55+#320
feat: add hyprlua — LuaCATS annotations for Hyprland 0.55+#320PhaedrusFlow wants to merge 4 commits into
Conversation
carsakiller
left a comment
There was a problem hiding this comment.
Your config.json file contains many "opinionated" settings such as Lua.completion.displayContext, Lua.diagnostics.workspaceDelay, etc. These are settings best left up to a user's preferences in their global settings, rather than being applied by this addon. It is equivalent to a VS Code extension forcing your theme and font family.
Also, there is no need to include Lua.workspace.library, as that setting is set by the addon manager.
|
Thanks so much for taking the time and consideration to provide your thoughtful insight! I've made changes based on my understanding of your intent, please let me know if I need to adjust further! |
carsakiller
left a comment
There was a problem hiding this comment.
There shouldn't be submodules within this submodule. Addons are meant to be small but you have many extra files and define submodules for https://github.com/hyprwm/Hyprland, https://github.com/LuaLS/LLS-Addons (recursive dependency?), https://github.com/LuaLS/addon-template (why?).
These shouldn't be necessary and add to the size considerably should someone install submodules recursively.
Adds lua_ls addon providing full EmmyLua/LuaCATS type annotations for
the Hyprland >= 0.55 Lua config API. Covers the
hl.*global,dispatchers (
hl.dsp.*), layout API, events, and typed configkeys.
Available on LuaRocks: https://luarocks.org/modules/phaedrusflow/hyprlua